Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1534467 - apiserver was not told how to output error response #647

Merged
merged 1 commit into from Jan 17, 2018

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:
Allows for the unauthorized requests to be returned as JSON

Changes proposed in this pull request

  • Thanks to Jordan Liggitt for helping me diagonse this one
  • The apiserver codec/seriallizer did not know how to deal with our
    unversioned api.

fixes (This will close that issue when PR gets merged)
fixes 1534467

* Thanks to Jordan Liggitt for helping me diagonse this one
* The apiserver codec/seriallizer did not know how to deal with our
unversioned api.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2018
@shawn-hurley shawn-hurley added bug 3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 labels Jan 17, 2018
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 241ee80 on shawn-hurley:bug-1534467 into ** on openshift:master**.

@jmrodri jmrodri merged commit ac7dba0 into openshift:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants