Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1534715 - Moves BindInstance retrieval and error handling to handler.go #648

Merged
merged 1 commit into from Jan 17, 2018

Conversation

mhrivnak
Copy link
Member

This matches how ServiceInstance retrieval takes place.

re #640

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2018
@jmrodri jmrodri self-requested a review January 17, 2018 19:38
@jmrodri jmrodri changed the title 1534715 - Moves BindInstance retrieval and error handling to handler.go Bug 1534715 - Moves BindInstance retrieval and error handling to handler.go Jan 17, 2018
@jmrodri jmrodri added the 3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 label Jan 17, 2018
…ler.go

This matches how ServiceInstance retrieval takes place.

re openshift#640
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling da94fc2 on mhrivnak:move-bind-check into ** on openshift:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling da94fc2 on mhrivnak:move-bind-check into ** on openshift:master**.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ACK

@jmrodri jmrodri added the bug label Jan 17, 2018
@jmrodri jmrodri merged commit 27da4f2 into openshift:master Jan 17, 2018
@mhrivnak mhrivnak deleted the move-bind-check branch January 18, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 | release-1.1 Kubernetes 1.9 | Openshift 3.9 | Broker release-1.1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants