Bug 1535652 - return 200 to bind PUT when a binding already exists #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
mhrivnak
force-pushed
the
bind-exists-return-200
branch
from
62495fe
to
c9e64a4
Compare
jmrodri
changed the title
jmrodri
approved these changes
Jan 17, 2018
| @@ -565,7 +565,7 @@ func (h handler) bind(w http.ResponseWriter, r *http.Request, params map[string] | |||
| switch err { | |||
| case broker.ErrorDuplicate: | |||
| writeResponse(w, http.StatusConflict, broker.BindResponse{}) | |||
| case broker.ErrorAlreadyProvisioned: | |||
| case broker.ErrorBindingExists: | |||
There was a problem hiding this comment.
nice catch. this was part of the copy from provision.
|
Changes Unknown when pulling c9e64a4 on mhrivnak:bind-exists-return-200 into ** on openshift:master**. |
|
Changes Unknown when pulling c9e64a4 on mhrivnak:bind-exists-return-200 into ** on openshift:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #649