Bug 1506978 - Apply proxy settings to running APBs #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Broker should inspect its own enviornment, and in the presence of a proxy configuration, should apply those settings to executing APBs.
openshift-ci-robot
added
the
size/L
|
Currently trying to test this in the example locked down environment, but I confirmed the settings are being applied to running APBs as expected when the various env vars are set. |
shawn-hurley
approved these changes
Jan 18, 2018
| httpsProxy, httpsProxyPresent := os.LookupEnv(httpsProxyEnvVar) | ||
| noProxy, noProxyPresent := os.LookupEnv(noProxyEnvVar) | ||
|
|
||
| // TODO: Probably some more permutations of these that should be validated? |
There was a problem hiding this comment.
Should this be made into an issue to be tracked?
There was a problem hiding this comment.
Yep. I can file an issue after this merges and follow up with a patch + tests. Need to figure out what combinations are valid vs. not valid.
| @@ -201,6 +215,52 @@ func createExtraVars(context *Context, parameters *Parameters) (string, error) { | |||
| return string(extraVars), err | |||
| } | |||
|
|
|||
| func createPodEnv(executionContext ExecutionContext) []v1.EnvVar { | |||
|
Changes Unknown when pulling 6826358 on eriknelson:proxy-bug into ** on openshift:master**. |
eriknelson
added
bug
3.9 | release-1.1
jmrodri
approved these changes
Jan 18, 2018
| }, | ||
| }, | ||
| }, | ||
| Env: createPodEnv(executionContext), |
| NoProxy: noProxy, | ||
| } | ||
| } | ||
|
|
| @@ -201,6 +215,52 @@ func createExtraVars(context *Context, parameters *Parameters) (string, error) { | |||
| return string(extraVars), err | |||
| } | |||
|
|
|||
| func createPodEnv(executionContext ExecutionContext) []v1.EnvVar { | |||
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* Broker should inspect its own enviornment, and in the presence of a proxy configuration, should apply those settings to executing APBs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a proxy configuration, should apply those settings to executing APBs.