Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail faster with travis #658

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Conversation

rthallisey
Copy link
Contributor

@rthallisey rthallisey commented Jan 18, 2018

Describe what this PR does and why we need it
Everything that runs in the scripts section won't error out on a failure. Move everything that is part of the setup for the CI job out of the scripts section so we fail faster if the setup fails.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2018
@rthallisey rthallisey force-pushed the travis-early-exit branch 3 times, most recently from df50694 to be94810 Compare January 19, 2018 12:29
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2018
@rthallisey rthallisey changed the title [WIP] Fail faster with travis Fail faster with travis Jan 19, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2018
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 255b11f on rthallisey:travis-early-exit into ** on openshift:master**.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmrodri jmrodri merged commit e670179 into openshift:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants