Remove ancient comment with app startup #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
Changes Unknown when pulling 4a75e54 on eriknelson:rm-main-comment into ** on openshift:master**. |
rthallisey
approved these changes
Jan 19, 2018
|
Is this PR to address issue #614 ? If so update the commit to include the issue number |
|
@jmrodri it's not. This is just removing an old comment that is tangentially related. 614 should get closed out with an implementation, IMO. |
shawn-hurley
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concern stands; we still want to consider graceful exit, but @maleck13 has raised some good points in #614 that sound like they're more golang-ish.