Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minishift docs and link to golden source #672

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

eriknelson
Copy link
Contributor

@eriknelson eriknelson commented Jan 22, 2018

  • github.com/minishift/minishift-addons README should be considered
    the golden source for working with a broker in minishift. This avoids
    spreading redundant docs across multiple repos, since the tooling will
    require it as well.

Depends on: minishift/minishift-addons#76

* github.com/minishift/minishift-addons README should be considered
the golden source for working with a broker in minishift. This avoids
spreading redundant docs across multiple repos, since the tooling will
require it as well.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2018
@eriknelson eriknelson added needs-review do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. labels Jan 22, 2018
@jmrodri jmrodri self-requested a review February 12, 2018 22:31
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@djzager djzager merged commit 80b7955 into openshift:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants