fixes #665 - remove many of the TODOs #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some in the files which I felt were still relevant or useful reminders.
openshift-ci-robot
added
the
size/M
shawn-hurley
approved these changes
Jan 22, 2018
rthallisey
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Nice @jmrodri. There are probably some TODOs that require a feature to add. We can remove those if there's a corresponding issue created to track the TODO. That may get us down a few more.
|
Merging without a bug because this is all comment removal with no functional changes. |
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
There are still some in the files which I felt were still relevant or useful reminders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced the TODO count from 60 to 38.
fixes #665