Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1506978 - Include lowercase proxy vars #683

Merged
merged 1 commit into from Jan 25, 2018

Conversation

eriknelson
Copy link
Contributor

  • We've seen the boto (not boto3) python lib expecting lowercase
    "http_proxy". Need to also include lowercase variants.

* We've seen the boto (*not* boto3) python lib expecting lowercase
"http_proxy". Need to also include lowercase variants.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2018
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I forgot about this. I had to do this when I added proxy support for subscription-manager.

@rthallisey rthallisey merged commit 6b0295a into openshift:master Jan 25, 2018
@eriknelson eriknelson deleted the proxy-bug branch January 25, 2018 18:59
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
* We've seen the boto (*not* boto3) python lib expecting lowercase
"http_proxy". Need to also include lowercase variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants