Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary dao ref from DeprovisionJob #691

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Remove unecessary dao ref from DeprovisionJob #691

merged 1 commit into from
Jan 26, 2018

Conversation

eriknelson
Copy link
Contributor

Removes dead ref on a DeprovisionJob

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2018
@jmrodri jmrodri self-requested a review January 26, 2018 05:31
maleck13
maleck13 approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also removed this in the last_op PR 👍

@eriknelson eriknelson merged commit 6481400 into openshift:master Jan 26, 2018
@eriknelson eriknelson deleted the remove-dao-ref branch January 26, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@maleck13 maleck13 maleck13 approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eriknelson @jmrodri @maleck13 @openshift-ci-robot