Add fall through case to deprovision handler #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
rthallisey
suggested changes
Jan 29, 2018
| @@ -443,6 +443,8 @@ func (h handler) deprovision(w http.ResponseWriter, r *http.Request, params map[ | |||
| case broker.ErrorDeprovisionInProgress: | |||
| writeResponse(w, http.StatusAccepted, broker.DeprovisionResponse{}) | |||
| return | |||
| default: | |||
| writeResponse(w, http.StatusInternalServerError, broker.ErrorResponse{Description: err.Error()}) | |||
There was a problem hiding this comment.
I think you also need a return after you respond with the error.
|
Thank you @philipgough! |
eriknelson
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Adds a default error to deprovision handler
Changes proposed in this pull request
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #698