Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1541335 - fix auth config parsing #728

Merged
merged 1 commit into from Feb 6, 2018
Merged

Bug 1541335 - fix auth config parsing #728

merged 1 commit into from Feb 6, 2018

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Feb 5, 2018

Added a test but it requires some directory to be installed on your desktop. I marked it as skip for now.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2018
@jmrodri jmrodri added bug 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 labels Feb 5, 2018
@jmrodri
Copy link
Contributor Author

jmrodri commented Feb 5, 2018

TEST

See plan from other PR
#729 (comment)

Copy link
Contributor

@rthallisey rthallisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. For some reason CI thinks this is a doc change :/

Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up @jmrodri !

@eriknelson eriknelson merged commit e118778 into master Feb 6, 2018
@eriknelson eriknelson deleted the bz1541335 branch February 6, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants