Bug 1539308 - Do not report errors on dupe depros #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* These logs suggest an unexpected error has occurred if broker::GetServiceInstance fails to find the instance. During the normal deprovision cycle, we will likely see multiple requests to deprovision the same instance. This method is called in the deprovision handler before it ever hits broker::Deprovision, so it's entirely normal for these etcd gets to miss. Therefore, these really aren't errors. Still useful to log however, as info.
openshift-ci-robot
added
the
size/XS
eriknelson
added
3.10 | release-1.2
rthallisey
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails to find the instance. During the normal deprovision cycle, we will
likely see multiple requests to deprovision the same instance. This
method is called in the deprovision handler before it ever hits
broker::Deprovision, so it's entirely normal for these etcd gets to
miss. Therefore, these really aren't errors. Still useful to log
however, as info.