Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1540121 - Remove redundant validation copy #741

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Bug 1540121 - Remove redundant validation copy #741

merged 1 commit into from
Feb 7, 2018

Conversation

eriknelson
Copy link
Contributor

  • Noticed an oversight in the recent update validation fix.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2018
@eriknelson eriknelson changed the title Fix validation bug Remove redundant validation copy Feb 7, 2018
@eriknelson eriknelson added the 3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 label Feb 7, 2018
@djzager
Copy link
Member

djzager commented Feb 7, 2018

ACK

@djzager djzager closed this Feb 7, 2018
@djzager djzager reopened this Feb 7, 2018
@djzager
Copy link
Member

djzager commented Feb 7, 2018

Confused Close with cancel. My bad.

djzager
djzager approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. That's better.

@eriknelson eriknelson changed the title Remove redundant validation copy Bug 1540121 - Remove redundant validation copy Feb 7, 2018
@eriknelson eriknelson merged commit a8af40d into openshift:master Feb 7, 2018
@eriknelson eriknelson deleted the val-fix-master branch February 7, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees
No one assigned
Labels
3.10 | release-1.2 Kubernetes 1.10 | Openshift 3.10 | Broker release-1.2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eriknelson @djzager @openshift-ci-robot