Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1542387 - Print out status of response from RHCC registry if not 200 #742

Merged
merged 1 commit into from Feb 7, 2018

Conversation

dymurray
Copy link
Member

@dymurray dymurray commented Feb 7, 2018

Describe what this PR does and why we need it:
Previous logging output was not helpful in determining the issue. Before we were getting 'invalid character' in the logs along with "Got Image Response from RHCC".

Now if RHCC fails to bootstrap it returns the status response (for current bug):

[2018-02-07T09:32:26.16-05:00] [ERROR] - unable to retrieve image names for registry rhcc - 500 INTERNAL SERVER ERROR

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2018
@eriknelson
Copy link
Contributor

Needs a PR to bring this into release-1.1 as well.

@dymurray
Copy link
Member Author

dymurray commented Feb 7, 2018

#743 <- release-1.1 PR

@jmrodri jmrodri added the bug label Feb 7, 2018
@jmrodri jmrodri self-requested a review February 7, 2018 15:11
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@eriknelson eriknelson merged commit 815d2fc into openshift:master Feb 7, 2018
jianzhangbjz pushed a commit to jianzhangbjz/ansible-service-broker that referenced this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants