Include necessary roles for local_openshift reg in simple-broker-template #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
jmrodri
changed the title
eriknelson
approved these changes
Feb 8, 2018
rthallisey
approved these changes
Feb 8, 2018
|
I will say at what point do we stop adding the features to the simple template. The simple template works as an example for the blog post. It worked just fine. What didn't work is if a users MODIFIES the template to add the local registry. In that case they also needed to add these entries. |
|
I think that is a fair point @jmrodri. It probably would also have worked to say, "use this other template instead" which actually includes the local OpenShift registry + all of the permissions required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Escalate asb service account privileges for simple-broker-template
Changes proposed in this pull request
Currently the up and running blog post is broken without this.