Introduce work-engine for asynchronous provisionining #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2017-04-06 10:49 jesus m. rodriguez error should not end in punctuation 2017-04-06 10:39 jesus m. rodriguez errors should not start with capital letter 2017-04-06 10:28 jesus m. rodriguez fix unit tests 2017-04-05 22:03 Erik Nelson ExtractedCredentials Refactor
* add LastOperation to Broker interface * add async support * adding subscriber for the provision messages * handle query parameter * add unit test for lastoperation
There were quite a few codes we were not properly sending back to the service catalog.
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
We are reusing the work-engine introduced in cap-server to allow the service broker to accept asynchronous provisioning requests. A number of things were added in this PR: * support for credentials during a provisioning call * asynchronous provisioning support * added last_operation api so the service catalog can monitor the provisioning jobs * updated provision to be spec compliant and return the proper return codes * added a mock registry The commits from this feature branch include: * Packaging updates * asbcli use new broker * Update org * Known good build * Container up retry logic * Mock reg * Merge spec metadata with service metadata * Tags support * Updated tag data * initial work_engine * add LastOperation to Broker interface * add async support * adding subscriber for the provision messages * handle query parameter * add unit test for lastoperation * add LoggingHandler * add gorilla/handler * fix unit tests * look for some common errors * return once error is done processing. * better logging messages * switch to using a different key structure * make provision more spec compliant * cleanup debug logging for parameters * some more test scripts * use instanceUUID for the extracted credentials. * remove unused file * Add refresh token logic (openshift#74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are reusing the work-engine introduced in cap-server to allow the service broker to accept asynchronous provisioning requests.
A number of things were added in this PR: