Bug 1541461 - Deal with buggy encoded scopes from service catalog. #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
shawn-hurley
added
bug
3.9 | release-1.1
eriknelson
approved these changes
Feb 12, 2018
eriknelson
added
3.10 | release-1.2
jmrodri
reviewed
Feb 12, 2018
| switch { | ||
| case ok && userInfo.Scopes != nil: | ||
| log.Infof("Unable to determine correct scope to use. Found both top level scope and scope in extras.") | ||
| return false, http.StatusForbidden, fmt.Errorf("unable to determine correct scope to use") |
There was a problem hiding this comment.
@shawn-hurley how likely is this situation? Will we get into a situation where we're screwed and always getting forbidden? What would cause both information to come in?
jmrodri
approved these changes
Feb 12, 2018
|
I believe the situation would not occur with just the service catalog. I
believe this is just to be very explicit about what would happen if it did.
There is no version of the service catalog this should happen on.
…On Mon, Feb 12, 2018 at 5:26 PM Jesus Rodriguez ***@***.***> wrote:
***@***.**** approved this pull request.
I have a question, but the code looks good.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#754 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABza98Ykc-m74v9lj7gIlGgbxq4SNX1Bks5tULqggaJpZM4SCnMJ>
.
|
|
@shawn-hurley okay, ACK! |
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Will allow us to handle scope that has been incorrectly encoded
Changes proposed in this pull request