Lock down everything in branch to this release #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djzager
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/XS
|
Thinking more about that...that's dumb, we can just use the canary image on release-1.0/release-1.1 branch for the broker images. |
jmrodri
reviewed
Feb 16, 2018
| @@ -418,7 +418,7 @@ parameters: | |||
| - description: Container Image to use for Ansible Service Broker in format of imagename:tag | |||
| displayname: Ansible Service Broker Image | |||
| name: BROKER_IMAGE | |||
| value: ansibleplaybookbundle/origin-ansible-service-broker:latest | |||
| value: ansibleplaybookbundle/origin-ansible-service-broker:release-1.0 | |||
There was a problem hiding this comment.
Do we just do this as part of our branching exercise?
There was a problem hiding this comment.
I believe we should. I think in the future, when we talk about branching, we should make sure the container images (and tags) exist for the branch and are up to date then create the new branch with these changes.
eriknelson
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so things in the
release-1.0branch userelease-1.0images + packages + etc.