Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace config to k8s deployment template #777

Merged
merged 1 commit into from
Feb 20, 2018
Merged

add namespace config to k8s deployment template #777

merged 1 commit into from
Feb 20, 2018

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:
This PR adds the required configuration value openshift.namespace

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2018
djzager
djzager approved these changes Feb 20, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

jmrodri
jmrodri approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jmrodri jmrodri merged commit 4cb8b78 into openshift:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@djzager djzager djzager approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shawn-hurley @jmrodri @djzager @openshift-ci-robot