parameterize the 'ansible-service-broker' namespace w/ NAMESPACE var #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
johnkim76
added
do-not-merge/work-in-progress
eriknelson
reviewed
Feb 28, 2018
| @@ -112,14 +112,14 @@ objects: | |||
| metadata: | |||
| name: access-asb-role | |||
| rules: | |||
| - nonResourceURLs: ["${BROKER_URL_PREFIX}", "${BROKER_URL_PREFIX}/*"] | |||
| - nonResourceURLs: ["/${BROKER_URL_PREFIX}", "/${BROKER_URL_PREFIX}/*"] | |||
There was a problem hiding this comment.
What's the necessity for this change?
johnkim76
force-pushed
the
parameterize_namespace
branch
from
ee07702
to
bd0b3dd
Compare
openshift-ci-robot
added
size/S
johnkim76
force-pushed
the
parameterize_namespace
branch
from
bd0b3dd
to
642dbd0
Compare
shawn-hurley
approved these changes
Mar 1, 2018
eriknelson
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the NAMESPACE var in the deployment template where applicable.