Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Broker's versioning strategy #810

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

djzager
Copy link
Member

@djzager djzager commented Mar 2, 2018

  • Document broker's compatibility with APBs
  • Document versioning and branching strategy

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2018
@djzager
Copy link
Member Author

djzager commented Mar 2, 2018

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, fix the link at the bottom of the second doc.

longer being added to the currently targeted OpenShift releases. When a new
branch is created, it will be named `release-MAJOR.MINOR` and the version in
the `master` branch will be bumped based on the rules in [Version
Format](#Version Format).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be Version Format

- Document broker's compatibility with APBs
- Document versioning and branching strategy
README.md Outdated

| ansible-service-broker | APB runtime 1 | APB runtime 2 |
|-----------------------------|---------------|---------------|
| ansible-service-broker 1.0 | ✓ | X |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also put the v3.7, v3.9 tags here?

targeted OpenShift Origin [release
v3.7.0](https://github.com/openshift/origin/releases/tag/v3.7.0). Following the
versioning rules, the version was bumped to `1.1.x` for OpenShift Origin [release
v3.9.0](https://github.com/openshift/origin/releases/tag/v3.9.0) and again to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link does not appear to be working for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This is because v3.9.0 is not yet released. I could point it to the release-3.9 branch....not sure the best way to handle that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh duh, that was silly. I think that pointing to the branch, for now, makes sense. Should we just remember to come back and update that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djzager djzager merged commit bcc8bfd into openshift:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants