Default to an open localregistry policy #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
djzager
approved these changes
Mar 9, 2018
| white_list: | ||
| - ".*-apb$" |
There was a problem hiding this comment.
Does it work if you just comment it out? Maybe just add it to the block comment.
There was a problem hiding this comment.
It would if you removed the white_list altogether, or just commented it out, but I sort of feel like it's not a bad thing to ask admins who would like to tweak this to write their own regex. Also there is an example immediately above for dockerhub.
rthallisey
approved these changes
Mar 9, 2018
jmrodri
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a default policy of only allowing APBs with a name suffixed by "-apb" has been confusing our development community. This change removes the above restriction by default. The justification for this change is that the deployment environments that use this template from the github repo include catasb, minishift, and
run_latest_build.sh. These are all specifically development environments.openshift-ansible, which is likely used for production deployments, carries its own production deployment template.fixes #823