Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] displayWhen for conditional rendering of fields #834

Closed
wants to merge 1 commit into from
Closed

[WIP] displayWhen for conditional rendering of fields #834

wants to merge 1 commit into from

Conversation

ruromero
Copy link
Member

Describe what this PR does and why we need it:

This allows APB developers to decide which form fields to render depending on conditions.
Uses https://github.com/json-schema-form/angular-schema-form/blob/0.8.13/docs/index.md#condition

Changes proposed in this pull request

  • Add new type to the apb.yml displayWhen
  • Convert displayWhen to condition adding model. to the variable
  • Update the documentation [TBD]

Does this PR depend on another PR (Use this to track when PRs should be merged)

N/A

Which issue this PR fixes (This will close that issue when PR gets merged)

N/A

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2018
@shawn-hurley shawn-hurley added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 15, 2018
@dymurray
Copy link
Member

Just posting for later... This can NOT get merged until we talk through the required APB spec version change. It's a minor change but let's just make sure we merge an associated PR into the ansible-playbook-bundle repo when this does get merged. Great work @ruromero!

@eriknelson eriknelson added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 16, 2018
@maleck13
Copy link
Contributor

Is this something that will be supported by the catalog UI? Very interested in being able to use this feature

@shawn-hurley shawn-hurley removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 20, 2018
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2018
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2018
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2018
@ruromero
Copy link
Member Author

Depends on automationbroker/bundle-lib#41

@maleck13
Copy link
Contributor

maleck13 commented Apr 4, 2018

should this also have been closed along with #859?

@shawn-hurley
Copy link
Contributor

@maleck13 Yes it should have been

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants