Display Custom Error Message for the APB via termination-log #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Could you provide an APB to be used to see this in action? |
shawn-hurley
added
the
do-not-merge
|
@djzager https://github.com/johnkim76/lastop-cem-demo-apb |
johnkim76
force-pushed
the
custom_error_msg
branch
6 times, most recently
from
511d4f2
to
4b46d6e
Compare
johnkim76
force-pushed
the
custom_error_msg
branch
from
4b46d6e
to
a9b690e
Compare
shawn-hurley
approved these changes
Mar 20, 2018
pkg/apb/watch_pod.go
Outdated
| @@ -36,6 +36,22 @@ var ( | |||
|
|
|||
| type updateDescriptionFn func(string) | |||
|
|
|||
| // ErrorCustomMsg - custom termination msg from pod's 'terminationMessagePath' | |||
There was a problem hiding this comment.
custom termination msg from pod's 'terminationMessagePath'
I think that this is generic enough that it could be used for any type of custom error message. What do you think of changing this to just say An error to propagate the custom error message to the callers
eriknelson
approved these changes
Mar 20, 2018
shawn-hurley
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
If the APB provision fails, this PR will check for a non-empty termination message, and will display it in the WebUI, instead of the generic error message.
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #675