Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make CRD the defaults for all templates #838

Merged
merged 2 commits into from Mar 28, 2018
Merged

make CRD the defaults for all templates #838

merged 2 commits into from Mar 28, 2018

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:

Changes proposed in this pull request

  • remove all references to asb-etcd as we should no longer use that
  • remove cert generation for asb-etcd from scripts 馃帀

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2018
@shawn-hurley
Copy link
Contributor Author

@openshift/sig-ansible-service-broker please help me test this patch for all the ways you run the broker. I have tried to test it completely.

@shawn-hurley shawn-hurley mentioned this pull request Mar 19, 2018
Merged
@shawn-hurley
Copy link
Contributor Author

Please use the changes for CATASB found in PR#219

@shawn-hurley
Copy link
Contributor Author

(21) Remove etcd from Broker and move to using CRDs

1 similar comment
@shawn-hurley
Copy link
Contributor Author

(21) Remove etcd from Broker and move to using CRDs

@shawn-hurley
Copy link
Contributor Author

Travis is failing due to CATASB changes that need to be merged.

fabianvf
fabianvf reviewed Mar 21, 2018
View reviewed changes
templates/deploy-ansible-service-broker.template.yaml
@@ -22,25 +22,6 @@ objects:
app: ansible-service-broker
service: asb

- apiVersion: v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting, these changes will need to be reflected in openshift-ansible once this is officially supported

rthallisey
rthallisey approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@rthallisey rthallisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me with openshift deployed via catasb.

@rthallisey
Copy link
Contributor

rthallisey commented Mar 26, 2018 •
edited

  • - run_latest_build.sh
  • - run_latest_k8s_build.sh (gate passed w/ this)
  • - catasb (worked for rhallisey)
  • - catasb k8s

@rthallisey rthallisey merged commit 7ad6632 into openshift:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf left review comments

@djzager djzager djzager approved these changes

@rthallisey rthallisey rthallisey approved these changes

Assignees
No one assigned
Labels
feature size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shawn-hurley @rthallisey @djzager @fabianvf @openshift-ci-robot