minor updates to proposal to clarify a few points #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
djzager
approved these changes
Mar 20, 2018
shawn-hurley
requested changes
Mar 20, 2018
docs/proposals/apb-state-support.md
Outdated
|
|
||
| ``` | ||
|
|
||
| Under the hood, this APB module would take the key-value pair, and store it in a | ||
| ConfigMap named ```$POD_NAME```. This ConfigMap would live within the | ||
| temporary namespace ```$POD_NAMESPACE``` and be created by the broker before the APB pod was created. | ||
| temporary namespace ```$POD_NAMESPACE``` and be created by the Service Bundle when with the first call to ```asb_set_state```. |
There was a problem hiding this comment.
Service Bundle when with the first call to...
Service Bundle on the first call to... ?
| After an action was successfully completed (ie the Service Bundle exited with a 0 exit code) and before the sandbox namespace was removed, the broker would copy the ConfigMap back to the broker's namespace and name it ```<ServiceInstanceID>-state```. If a ConfigMap with | ||
| that name was already present, the broker would update and append the values. | ||
| There should only ever be one ConfigMap per ServiceInstance. The ConfigMap would be removed from the broker's namespace | ||
| once the the deprovision action completed successfully. | ||
| once the the deprovision action was invoked for that ServiceInstance. |
There was a problem hiding this comment.
This is fine for now. I think that soon we will need to worry about subsequent deprovsion calls after a failed deprovsion. I think this is something that the service catalog is working on.
|
@shawn-hurley updated wording |
shawn-hurley
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to ensure the proposal lines up with what will be done.