Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bundle lib #848

Merged
merged 7 commits into from Mar 23, 2018
Merged

Use bundle lib #848

merged 7 commits into from Mar 23, 2018

Conversation

shawn-hurley
Copy link
Contributor

Describe what this PR does and why we need it:

changes to allow for use of bundle lib in this project

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 22, 2018
@djzager
Copy link
Member

djzager commented Mar 22, 2018

I'm disappointed the @openshift-ci-robot did not laugh at you.

@jmrodri
Copy link
Contributor

jmrodri commented Mar 22, 2018

@shawn-hurley can you summarize the changes in a comment? The files changed diff is useless

@shawn-hurley
Copy link
Contributor Author

  • moving pkg/apb, pkg/clients, pkg/origin, pkg/registries, pkg/registries/adapters, pkg/runtime to bundle-lib
  • vendor bundle-lib
  • move CRD conversion logic in DAO to use bundle-lib
  • update NewRuntime call in app.go to use new configuration struct

eriknelson
eriknelson approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 🌮

dymurray
dymurray approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Stuff!!!

jmrodri
jmrodri approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@eriknelson eriknelson merged commit d6cd300 into master Mar 23, 2018
@eriknelson eriknelson deleted the use-bundle-lib branch March 23, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@eriknelson eriknelson eriknelson approved these changes

@rthallisey rthallisey rthallisey approved these changes

@dymurray dymurray dymurray approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shawn-hurley @djzager @jmrodri @eriknelson @rthallisey @dymurray @openshift-ci-robot