Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind the user to give the developer cluster-admin #857

Merged
merged 1 commit into from Mar 28, 2018

Conversation

rthallisey
Copy link
Contributor

Describe what this PR does and why we need it:

Lots of folks use run_latest_build.sh with the apb tool. But, when run_latest_build.sh completes, the script suggests the user login to the developer user in order to use the apb tool. The developer user by default doesn't have permission to contact the broker in the ansible-service-broker namespace so the apb tool isn't going to work.

Changes proposed in this pull request

  • Print a command to give the developer user cluster-admin

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2018
@eriknelson
Copy link
Contributor

eriknelson commented Mar 26, 2018

cluster-admin seems okay for this script, since it was never intended to support regular apb devlopment and use (it was "hey, try out the broker really quick!"). Unfortunately, a lot of people continue to rely on it.

FYI, this template is used by minishift to permission developer with all of its rules that it requires and nothing more. https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/blob/master/templates/openshift-permissions.template.yaml

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shawn-hurley shawn-hurley merged commit dab880c into openshift:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants