Bump to bundle-lib 0.1.1 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
commented
Mar 27, 2018
shawn-hurley
commented
- bump automationbroker/bundle-lib to 0.1.1
openshift-ci-robot
added
the
size/XXL
shawn-hurley
changed the title
shawn-hurley
commented
Mar 27, 2018
| BlackList: config.GetSliceOfStrings("black_list"), | ||
| AuthType: config.GetString("auth_type"), | ||
| AuthName: config.GetString("auth_name"), | ||
| Runner: config.GetString("runner"), |
There was a problem hiding this comment.
@djzager Making sure this is what you were expecting.
There was a problem hiding this comment.
Why are we copying configs everywhere now? Feels like I missed something.
rthallisey
approved these changes
Mar 27, 2018
djzager
approved these changes
Mar 28, 2018
* bump automationbroker/bundle-lib to 0.1.1
shawn-hurley
force-pushed
the
remove-config-package-bundle-lib
branch
from
b17ac01
to
66e8bd4
Compare
jmrodri
suggested changes
Mar 29, 2018
| packages = ["."] | ||
| revision = "15d8430ab86497c5c0da827b748823945e1cf1e1" | ||
| version = "v1.4.0" | ||
|
|
There was a problem hiding this comment.
Why does bumping bundle-lib bring in a new semver? I never understood why we can't just bring in a single updated library.
There was a problem hiding this comment.
because semver was added to bundle lib for @djzager helm adapter.
| BlackList: config.GetSliceOfStrings("black_list"), | ||
| AuthType: config.GetString("auth_type"), | ||
| AuthName: config.GetString("auth_name"), | ||
| Runner: config.GetString("runner"), |
There was a problem hiding this comment.
Why are we copying configs everywhere now? Feels like I missed something.
|
We are moving all uses of the |
jmrodri
approved these changes
Mar 29, 2018
eriknelson
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.