make more than one stage for all the tasks we want to do. #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this should make it easier to see what failed * should allow for easier gate debugging
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
size/M
djzager
reviewed
Mar 28, 2018
.travis.yml
Outdated
| - stage: "Format" | ||
| script: | ||
| - ./scripts/travis.sh format | ||
| - stage: "Vet" |
There was a problem hiding this comment.
Can "Format", "Vet", and "Lint" all be put under a single stage "Lint"?
.travis.yml
Outdated
| script: | ||
| - ./scripts/travis.sh build | ||
|
|
||
| - stage: "OpenShift CI" |
There was a problem hiding this comment.
I think this comment is outside the scope of this PR, but I was thinking it would be nice if these "OpenShift CI" and "Kubernetes CI" were separate tests belonging to the same stage "Functional Testing".
djzager
approved these changes
Mar 28, 2018
openshift-ci-robot
added
size/S
shawn-hurley
force-pushed
the
make-more-travis-jobs
branch
2 times, most recently
from
4cd9494
to
d5260ae
Compare
openshift-ci-robot
added
size/M
Closed
shawn-hurley
force-pushed
the
make-more-travis-jobs
branch
from
256f3b0
to
061e3fa
Compare
eriknelson
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it: