Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a table to track release dates #879

Merged
merged 2 commits into from Apr 6, 2018
Merged

Add a table to track release dates #879

merged 2 commits into from Apr 6, 2018

Conversation

rthallisey
Copy link
Contributor

Describe what this PR does and why we need it:

Add release dates to the README.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2018
jmrodri
jmrodri approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the YYYY-MM-DD format for the date, I think it would be more internationally friendly.

For example, 10/4/2018 is October 4th in the US but to some in Europe it is April 10th.

@shawn-hurley
Copy link
Contributor

👍 on the international date format but I like if we add this!

djzager
djzager requested changes Apr 6, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could move this up to (or take over) the versioning section of the readme, IMHO, that would be better. This feels like the kind of thing I should have included with that PR 😎.

Other than that, this looks good to me. 👍 to the date format.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2018
@jmrodri jmrodri merged commit b401247 into openshift:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@djzager djzager djzager approved these changes

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rthallisey @shawn-hurley @jmrodri @djzager @openshift-ci-robot