Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 1564542 #881

Merged
merged 2 commits into from Apr 9, 2018
Merged

Fix bug 1564542 #881

merged 2 commits into from Apr 9, 2018

Conversation

maleck13
Copy link
Contributor

@maleck13 maleck13 commented Apr 9, 2018

Describe what this PR does and why we need it:

This fixes bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1564542

Changes proposed in this pull request

  • add an EnsureDefaults() to the parameters type that sets a default value for _apb_provision_creds var. More could be added in the future.

Which issue this PR fixes (This will close that issue when PR gets merged)

fixes #818

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 9, 2018
@maleck13
Copy link
Contributor Author

maleck13 commented Apr 9, 2018

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shawn-hurley
Copy link
Contributor

Thanks for the bug fix @maleck13

@shawn-hurley shawn-hurley merged commit 476bd79 into openshift:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass provision credentials to the deprovision playbook even if APB is not bindable
4 participants