Bug 1565648 - expose _apb_service_binding_id to bind role #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
djzager
approved these changes
Apr 10, 2018
| @@ -835,19 +835,23 @@ func (a AnsibleBroker) Bind(instance apb.ServiceInstance, bindingUUID uuid.UUID, | |||
| planParameterKey, plan.Name) | |||
|
|
|||
| params[planParameterKey] = plan.Name | |||
|
|
|||
pb82
changed the title
|
@djzager Thanks for the review, creating a bugzilla account now |
|
That was my fault @pb82. I was not clear. We are currently under a feature freeze. In order for this PR to be merged into |
|
Thank you for @pb82 for your contribution. It is appreciated. |
pb82
changed the title
|
@djzager No problem, i've created a bug in Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1565648 Also updated the title. |
shawn-hurley
changed the title
|
Thank you again. |
shawn-hurley
approved these changes
Apr 10, 2018
maleck13
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
This PR exposes a new parameter
_apb_service_binding_idto the bind role that contains the externalId of the associated service binding. This is useful in cases where you want to triggerunbindby deleting the service instance.Changes proposed in this pull request
_apb_service_binding_idto the injected parameters for theBindaction.Does this PR depend on another PR (Use this to track when PRs should be merged)
No
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565648
ping @maleck13 @shawn-hurley