Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 882 - Simple broker template should use release-1.1 instead of a sprint tag #885

Merged
merged 1 commit into from Apr 11, 2018
Merged

Issue 882 - Simple broker template should use release-1.1 instead of a sprint tag #885

merged 1 commit into from Apr 11, 2018

Conversation

djzager
Copy link
Member

@djzager djzager commented Apr 10, 2018

Describe what this PR does and why we need it:

Update the images used by the simple-broker-template to be release-1.1 branch.

$ docker run -it --entrypoint asbd docker.io/ansibleplaybookbundle/origin-ansible-service-broker:sprint142 --version
1.1.3

$ docker run -it --entrypoint asbd docker.io/ansibleplaybookbundle/origin-ansible-service-broker:release-1.1 --version
1.1.15

Which issue this PR fixes (This will close that issue when PR gets merged)

fixes #882

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2018
@djzager
Copy link
Member Author

djzager commented Apr 10, 2018

Not associating a bug with this as it's just a template change for upstream.

@djzager djzager requested a review from jmrodri April 10, 2018 16:54
@jmrodri
Copy link
Contributor

jmrodri commented Apr 11, 2018

@djzager why should it use release-1.1? Also the commit message should be "Issue 882 - Simple broker template should use release-1.1 instead of a sprint tag"

@djzager djzager changed the title Simple broker template should use release-1.1 instead of a sprint tag Issue 882 - Simple broker template should use release-1.1 instead of a sprint tag Apr 11, 2018
@djzager
Copy link
Member Author

djzager commented Apr 11, 2018 •
edited

@jmrodri I believe it should be using release-1.1 as the sprint142 tag 1) is not working 2) release-1.1 is a tag we would potentially update with fixes.

Title updated. Will mod commit message also.

@djzager
Issue 882 - Simple broker template use release-1.1
008f073 
Sprint142 isn't working correctly and release-1.1 tag is something we
could potentially update for 3.9 related fixes.

- Update simple broker template to use release-1.1 tagged images
jmrodri
jmrodri approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks for the explanation.

@jmrodri jmrodri merged commit d00705d into openshift:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot deploy ansible service broker because of missing docker image tag
3 participants
@djzager @jmrodri @openshift-ci-robot