Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass ROUTING_SUFFIX parameter #887

Closed
wants to merge 1 commit into from
Closed

pass ROUTING_SUFFIX parameter #887

wants to merge 1 commit into from

Conversation

SaravanaStorageNetwork
Copy link
Contributor

@SaravanaStorageNetwork SaravanaStorageNetwork commented Apr 12, 2018 •
edited

pass ROUTING_SUFFIX parameter to deploy-ansible-service-broker template

Describe what this PR does and why we need it:

ROUTING_SUFFIX is having default value in deploy-ansible-service-broker template.
It may have different value if user wishes.

So, pass the same as parameter.

Changes proposed in this pull request

  • Pass ROUTING_SUFFIX as a parameter to deploy-ansible-service-broker template

@SaravanaStorageNetwork
pass ROUTING_SUFFIX parameter
9375433 
pass ROUTING_SUFFIX parameter to deploy-ansible-service-broker template
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2018
@jmrodri jmrodri self-requested a review April 24, 2018 13:59
@rthallisey rthallisey self-requested a review April 24, 2018 13:59
jmrodri
jmrodri approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, needs a rebase.

djzager
djzager requested changes Apr 25, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed anymore as the run_latest_build.sh is using the broker-apb.

@openshift-bot
Copy link

@SaravanaStorageNetwork: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2018
@djzager
Copy link
Member

djzager commented May 14, 2018 •
edited

#939 removes the use of templates (and actually deprecates) run_latest_build.sh. I think we should close this PR in favor of adding the broker, and associated automation, to the project.

@rthallisey
Copy link
Contributor

#939

@rthallisey rthallisey closed this May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager requested changes

@jmrodri jmrodri jmrodri approved these changes

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SaravanaStorageNetwork @openshift-bot @djzager @rthallisey @jmrodri @openshift-ci-robot