Bug 1565545 - Adding migration of extracted credentials #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
shawn-hurley
force-pushed
the
bug-1565545
branch
from
aef3367
to
90eeabd
Compare
dymurray
approved these changes
Apr 25, 2018
jmrodri
suggested changes
Apr 25, 2018
cmd/migration/main.go
Outdated
| revertBindInstance(biSaved) | ||
| revertServiceInstance(siSaved) | ||
| revertCrdSavedSpecs(crdSavedSpecs) | ||
| panic(fmt.Sprintf("Unable to migrate all extracted credentials - %v", err)) |
There was a problem hiding this comment.
would we want to see which extracted credential failed to migrate?
| revertCrdSavedSpecs(crdSavedSpecs) | ||
| panic(fmt.Sprintf("Unable to migrate all extracted credentials - %v", err)) | ||
| } | ||
| k8scli, err := clients.Kubernetes() |
There was a problem hiding this comment.
this feels out of place, like we should've gotten this early on in the process before we even tried to get any of the extracted credentials. I guess it's okay here, just feels weird.
There was a problem hiding this comment.
Is this something that you want me to change?
| Namespace: options.MigrationNamespace, | ||
| }) | ||
| } | ||
| for _, bi := range biSaved { |
There was a problem hiding this comment.
We need a comment between the different sections:
//
// Convert Binding Instances
//
...
//
// Converting Extracted Credentials
//
...
There was a problem hiding this comment.
what's with the 3 commented lines?
jmrodri
approved these changes
May 1, 2018
eriknelson
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Currently we do not migrate extracted credentials to the new mode of saving/retrieving/updating/deleting credentials.
Changes proposed in this pull request
Which issue this PR fixes (This will close that issue when PR gets merged)
https://bugzilla.redhat.com/show_bug.cgi?id=1565545