Bug 1533425 - protect against simultaneous updates #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Simultaneous calls to SetState or SetBindingInstance would fail with an already exists error instead of graciously updating the existing instances. Also, the broker.Bind was incorrectly trying to set the state of a binding job using the instance id as the key, vs use bindingid for state in bindings
jmrodri
force-pushed
the
fix_binding_state
branch
from
1382691
to
8f2840b
Compare
jmrodri
changed the title
shawn-hurley
requested changes
Apr 19, 2018
pkg/dao/crd/dao.go
Outdated
| // looks like we already have this state, probably created by | ||
| // another goroutine. Let's try to update the existing one instead. | ||
| if js, err := d.client.JobStates(d.namespace).Get(state.Token, metav1.GetOptions{}); err == nil { | ||
| js.Spec = j |
There was a problem hiding this comment.
Should this be in a helper function?
pkg/broker/broker.go
Outdated
| }); err != nil { | ||
| log.Errorf("failed to set initial jobstate for %v, %v", token, err.Error()) | ||
| } | ||
| // if _, err := a.dao.SetState(bindInstance.ID.String(), apb.JobState{ |
There was a problem hiding this comment.
Just my opinion but if the code is not running can we delete it?
We can also go back in history with git and re-add it back?
|
@shawn-hurley refactored update code into a method. Let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protect against simultaneous updates
Simultaneous calls to SetState or SetBindingInstance would fail with an already exists error instead of graciously updating the existing instances.
Also, the broker.Bind was incorrectly trying to set the state of a binding job using the instance id as the key, vs use bindingid for state in bindings