Add PUSH_IMAGE var to allow image to be pushed #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are quite a few times I run make build-image ORG=jmrodri and I immediately call docker push afterwards. This allows me to let the makefile do it if I want it to.
openshift-ci-robot
added
the
size/XS
djzager
requested changes
Apr 20, 2018
| @@ -2,6 +2,7 @@ REGISTRY ?= docker.io | |||
| ORG ?= ansibleplaybookbundle | |||
| TAG ?= latest | |||
There was a problem hiding this comment.
I think if this is something we want then we have to make it more dummy proof. At a minimum I think you must set TAG to be something like:
TAG ?= $(shell git rev-parse short HEAD)
That will prevent people from accidentally using the makefile to break the "latest" broker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite a few times I run make build-image ORG=jmrodri and I
immediately call docker push afterwards. This allows me to let the
makefile do it if I want it to.