fix statements with formatting #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making broker consistent with the log statements in bundle-lib, i.e. use the *f version when logging formatting strings. It is most important when using logrus, go-logging seems to handle it okay. But this PR will make it easier to move to logrus in the future. See PR #61 from bundle-lib for more information: automationbroker/bundle-lib#61
openshift-ci-robot
added
the
size/M
pkg/app/app.go
Outdated
| @@ -42,7 +42,7 @@ import ( | |||
| "github.com/automationbroker/bundle-lib/registries" | |||
| agnosticruntime "github.com/automationbroker/bundle-lib/runtime" | |||
| "github.com/automationbroker/config" | |||
| "github.com/jessevdk/go-flags" | |||
| flags "github.com/jessevdk/go-flags" | |||
There was a problem hiding this comment.
Does this not cause issues?
There was a problem hiding this comment.
interesting goimports changed this, On an old version of goimports, it completely removed it, and on the other machine it added the above. I'll fix it using gedit :) But no it didn't seem to cause any issues since we're not also importing the system flags.
There was a problem hiding this comment.
So goimports won't touch it now that I fixed it. It's weird that go-flags is actually used as flags.
shawn-hurley
approved these changes
Apr 23, 2018
djzager
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making broker consistent with the log statements in bundle-lib, i.e. use
the *f version when logging formatting strings. It is most important
when using logrus, go-logging seems to handle it okay. But this PR will
make it easier to move to logrus in the future.
See PR #61 from bundle-lib for more information:
automationbroker/bundle-lib#61