Merge run_latest_k8s_build into run_latest_build script #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
shawn-hurley
requested changes
May 3, 2018
| echo " You must also enable the service-catalog. This depends on the installed origin" | ||
| echo " client version." | ||
| echo " Origin client version < 3.10 \`--service-catalog=true\`." | ||
| echo " Origin client version >= 3.10 \`--enable=service-catalog\`." |
There was a problem hiding this comment.
Question: Do we need PVs installed as well, will it work if you only have just service-catalog?
There was a problem hiding this comment.
I'm going to try this on an oc cluster up without pvs to check. My initial reaction is no.
|
fixes: #912 |
shawn-hurley
approved these changes
May 8, 2018
|
Closing in favor of #939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #912 #931