Bug 1572470 - use binding id as instance, do not error on conflict #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmrodri
commented
May 3, 2018
jmrodri
commented
- CRDs use the binding id alone switched to using binding id.
- Generate the statekey for use in etcd in the broker.go
- Make logs informative, some now include the k8s reason
- A conflicting update is now simply logged and skipped
openshift-ci-robot
added
the
size/M
rthallisey
added
3.10 | release-1.2
shawn-hurley
requested changes
May 3, 2018
pkg/broker/broker.go
Outdated
| } | ||
|
|
||
| bindingInstance.CreateJobKey = stateKey | ||
| bindingInstance.CreateJobKey = fmt.Sprintf("/state/%s/job/%s", instance.ID.String(), token) |
There was a problem hiding this comment.
isn't the job state subscriber using the binding id for the instance ID? If this is the case then we are will not update this job state and that could cause issues for recovery I think.
| if err != nil { | ||
| log.Errorf("Unable to update the service binding, after a failed creation: %v - %v", id, err) | ||
|
|
||
| if err != nil && apierrors.IsConflict(err) { |
There was a problem hiding this comment.
If you wanted we could also see if there is something in the spec that that has changed? this would allow us to alert that an actual update was missed?
* CRDs use the binding id alone switched to using binding id. * Generate the statekey for use in etcd in the broker.go * Make logs informative, some now include the k8s reason * A conflicting update is now simply logged and skipped
shawn-hurley
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.