Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1572129 - remove unnecessary SetState #927

Merged
merged 1 commit into from May 4, 2018
Merged

Bug 1572129 - remove unnecessary SetState #927

merged 1 commit into from May 4, 2018

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented May 4, 2018

  • cleaned up a bunch of logging to use *f formatted form
  • removed the SetState that causes update conflicts
  • cleaned up the dao logging to be more informative
  • changed formatting to be more narrow :)

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2018
@jmrodri
Copy link
Contributor Author

jmrodri commented May 4, 2018 

[2018-05-04T02:57:29.055Z] [INFO] - Initiating Recovery Process                                                                                                                                                   
[2018-05-04T02:57:29.068Z] [DEBUG] - get service instance: dea8214c-4f46-11e8-b11d-0242ac110009                                                                                                                   
[2018-05-04T02:57:29.077Z] [DEBUG] - get spec: 1dd62d51c52cc2ac404d58abc0c8fa94                                                                                                                                   
[2018-05-04T02:57:29.089Z] [INFO] - No podname. Attempting to restart job: dea8214c-4f46-11e8-b11d-0242ac110009                                                                                                   
[2018-05-04T02:57:29.089Z] [DEBUG] - &{dea8214c-4f46-11e8-b11d-0242ac110009 0xc42028f4a0 0xc4205ba0a0 0xc42048a310 map[] }                                                                                        
[2018-05-04T02:57:29.089Z] [INFO] - Recovery complete                                                                                                                                                             
[2018-05-04T02:57:29.089Z] [NOTICE] - recover called

@jmrodri jmrodri added the bug label May 4, 2018
@jmrodri
Bug 1572129 - remove unnecessary SetState
43c1f72 
* cleaned up a bunch of logging to use *f formatted form
* removed the SetState that causes update conflicts
* cleaned up the dao logging to be more informative
* changed formatting to be more narrow :)
@jmrodri jmrodri merged commit c772f7c into master May 4, 2018
@jmrodri jmrodri deleted the recovery branch May 31, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@eriknelson eriknelson Awaiting requested review from eriknelson

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmrodri @djzager @shawn-hurley @openshift-ci-robot