Add parsing of param dependencies #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
2 tasks
|
@jmrodri example of this working with the catalog pr linked above |
|
Please see my comments in bundle-lib#70 about documentation updates and incrementing of the bundle spec to |
shawn-hurley
added
the
3.11 | release-1.3
|
cc @maleck13 Still work to be done here but be nice to get some early feedback. |
openshift-ci-robot
added
size/XXL
philipgough
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
shawn-hurley
requested changes
Jun 6, 2018
pkg/broker/util_test.go
Outdated
| }, | ||
| } | ||
|
|
||
| expectDependencyJson := ` |
There was a problem hiding this comment.
Lint is complaining should be expectDependencyJSON
openshift-ci-robot
added
size/XXL
|
@shawn-hurley I've update the bundle-lib dependency as part of this PR FYI |
shawn-hurley
approved these changes
Jul 11, 2018
Add test for dependency extraction
jmrodri
approved these changes
Jul 11, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Ready for review
Change to parse the dependencies defined by apb.yml and map them to valid json schemas
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on automationbroker/bundle-lib#70
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #859