Add fix for get si npe #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
shawn-hurley
approved these changes
May 4, 2018
|
Pretty soon we can start to write tests for the broker if we want. We have mocked for dao and we just need to figure out the mocks for apb.Executor/async engine. Just a thought for later |
djzager
approved these changes
May 4, 2018
jmrodri
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shawn-hurley and I discovered a panic this morning. If for some reason the catalog has a bunch of instances that the broker is unaware of, the broker will try to lookup the instance, fail to find it, and panic when trying to deref the spec off a nil value. This correctly checks the error.