Add requested parameters when not in existing service instance #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
shawn-hurley
reviewed
May 8, 2018
pkg/broker/broker.go
Outdated
| @@ -1398,6 +1398,7 @@ func (a AnsibleBroker) validateRequestedUpdateParams( | |||
| // can make sense of them. | |||
| log.Noticef("Requested update parameter: [%v] with the value of [%v] was found " + | |||
| "in an update request, but it did not exist on the previous service instance.") | |||
| changedParams[reqParam] = reqVal | |||
There was a problem hiding this comment.
If this is all we are going to do then we should just remove the entire if/else chain and always update IMO
openshift-ci-robot
added
size/S
djzager
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
djzager
added
the
do-not-merge/hold
|
This should go against master once |
rthallisey
approved these changes
May 14, 2018
rthallisey
added
the
3.10 | release-1.2
djzager
added
3.11 | release-1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the requested update parameter to the changed parameters when not found in the existing serviceinstance.
Fixes: #934