Bug 1576728 - Fixes multiple requests to a CR #947
Conversation
openshift-ci-robot
added
the
size/M
Gopkg.lock
Outdated
| @@ -44,6 +44,7 @@ | |||
| version = "0.1.2" | |||
|
|
|||
| [[projects]] | |||
| branch = "bug-1576728" | |||
There was a problem hiding this comment.
will this remain when we merge?
Gopkg.toml
Outdated
| version = "~0.1.0" | ||
| #version = "~0.1.0" | ||
| branch = "bug-1576728" | ||
| source = "github.com/shawn-hurley/bundle-lib" |
There was a problem hiding this comment.
No, this depends on this automationbroker/bundle-lib#80
| bundleLock: sync.Mutex{}, | ||
| bindingLock: sync.Mutex{}, | ||
| instanceLock: sync.Mutex{}, | ||
| } |
There was a problem hiding this comment.
CRDs suck as a database :)
shawn-hurley
added
the
3.10 | release-1.2
There was a problem hiding this comment.
ACK, discussed with @shawn-hurley and @jmrodri. Determined best course of action for 3.10 until a longer term fix can be employed in 3.11.
@shawn-hurley can we file an issue that describes why this isn't the desired long-term fix and potential avenues to explore for a longer term fix?
Also, these Gopkg refs need to be updated after we cut a bundle-lib release with the related fix, correct?
| namespace string | ||
| client automationbrokerv1.AutomationbrokerV1alpha1Interface | ||
| namespace string | ||
| bundleLock sync.Mutex |
|
automationbroker/bundle-lib#80 just merged. Should be able to remove |
|
@rthallisey I think we probably want to update the Gopkg stuff to reference a release tag of bundle-lib. |
openshift-ci-robot
added
size/L
shawn-hurley
changed the title
|
This is ready to merge with the bundle lib release. |
Describe what this PR does and why we need it:
This makes the dao calls happen 1 at a time for a dao. Attempts to handle the case when two service instances are gotten with two bindings. both are deleted, but because we only remove each of one, and when we update we just set the value, we were adding back a binding.
Depends on automationbroker/bundle-lib#80