dep prune vendor #962
Merged
dep prune vendor #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
|
||
| [prune] | ||
| unused-packages = true | ||
| go-tests = true |
There was a problem hiding this comment.
Should we add non-go = true to this as well it will reduce the size to 40M?
unused-packages = true => files from directories that do not appear in
the package import graph should be pruned
non-go = true => prunes files that are not used by Go
go-tests = true => prunes Go test files
dep now can remove tests and non-go files from dependencies which bloat the repo. There is no reason to have these files in the repo as they do not get compiled.
|
@shawn-hurley switched to using all three options as true. |
shawn-hurley
approved these changes
May 21, 2018
eriknelson
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dep now can remove tests and non-go files from dependencies which bloat
the repo. There is no reason to have these files in the repo as they do
not get compiled.
The BEST part is the vendor tree shrinks dramatically.
Before the prune:
After the prune: