Bug 1581580 - skip if bind instance does not have credentials #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
size/XS
djzager
approved these changes
May 23, 2018
cmd/migration/main.go
Outdated
| @@ -239,6 +239,11 @@ func main() { | |||
| for _, bi := range biSaved { | |||
| labels := map[string]string{"apbAction": "bind"} | |||
| extcredsJSON, err := etcdDao.GetRaw(fmt.Sprintf("/extracted_credentials/%v", bi.ID)) | |||
| // If no extracted credential for the binding, then it is using the service instance's | |||
| // extracted credentials and we should assume that this is the case. | |||
There was a problem hiding this comment.
are we basically just saying, it's okay if a binding has no extracted credentials?
openshift-ci-robot
added
size/S
eriknelson
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.