Bug 1583064 - missing action causes many sandboxes #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the unbind fails we really want to let them know it failed because it is probably something the APB developer needs to fix. But if the action is non-existent we really need to prevent the multiple sandboxes. If we can't find the action, there is no point in continuing. marking job as SUCCEEDED but setting the message to be the actual error string. This will only happen for the optional actions: bind & unbind. Update isJobInProgress to take a string to allow the proper ID to be passed in.
openshift-ci-robot
added
the
size/M
jmrodri
added
the
3.11 | release-1.3
shawn-hurley
approved these changes
May 30, 2018
| @@ -732,7 +732,7 @@ func (a AnsibleBroker) Deprovision( | |||
| return nil, err | |||
| } | |||
|
|
|||
| alreadyInProgress, jobToken, err := a.isJobInProgress(&instance, apb.JobMethodDeprovision) | |||
| alreadyInProgress, jobToken, err := a.isJobInProgress(instance.ID.String(), apb.JobMethodDeprovision) | |||
pkg/broker/job_state_subscriber.go
Outdated
| @@ -35,6 +36,28 @@ func (jss *JobStateSubscriber) Notify(msg JobMsg) { | |||
| if isBinding(msg) { | |||
| id = msg.BindingUUID | |||
| } | |||
|
|
|||
| log.Debugf("message: method: [%v] isNotFound? [%v] state error [%v]", msg.State.Method, msg.State.Error == runtime.ErrorActionNotFound.Error(), msg.State.Error) | |||
There was a problem hiding this comment.
NIT: I think this might have been for testing is it still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the unbind fails we really want to let them know it failed because it
is probably something the APB developer needs to fix. But if the action
is non-existent we really need to prevent the multiple sandboxes.
If we can't find the action, there is no point in continuing.
marking job as SUCCEEDED but setting the message to be the actual error
string. This will only happen for the optional actions: bind & unbind.
Update isJobInProgress to take a string to allow the proper ID to be
passed in.